Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support 'adaptiveCard/action' in Teams handler #3716

Merged
merged 5 commits into from
Jun 3, 2021

Conversation

cfe84
Copy link
Contributor

@cfe84 cfe84 commented Jun 1, 2021

Fixes #3715

Description

When using Universal Action Model, Adaptive Cards are sending an activity with name adaptiveCard/action. This commit adds a handler for that type to the teamsActivityHandler in order to support UAM.

Specific Changes

  • Add handler handleAdaptiveCardAction to teamsActivityHandler
  • Add logic in onInvokeActivity to call this handler when invoke name is adaptiveCard/action
  • Add an AdaptiveCardActionResponse type to the botbuilder-core interfaces

Testing

  • Added corresponding unit-tests
  • Tested with an app

3715: Adaptive Cards are sending an activity with name
"adaptiveCard/action". Added a handler for that type to the
teamsActivityHandler in order to support this.
@cfe84 cfe84 requested a review from a team as a code owner June 1, 2021 03:42
@ghost
Copy link

ghost commented Jun 1, 2021

CLA assistant check
All CLA requirements met.

@coveralls
Copy link

coveralls commented Jun 1, 2021

Pull Request Test Coverage Report for Build 900612851

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 85.341%

Totals Coverage Status
Change from base Build 900609174: 0.1%
Covered Lines: 19237
Relevant Lines: 21437

💛 - Coveralls

@joshgummersall joshgummersall merged commit ef2b7af into microsoft:main Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TeamsActivityHandler default handler method for adaptiveCard/action
3 participants