Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: Allow back quotes in adaptive expression object and array construction #3700

Merged
merged 1 commit into from
May 19, 2021

Conversation

Danieladu
Copy link
Contributor

Fixes #3699

Description

Allow back quotes in adaptive expression object and array construction

Samples:

# StringTemplateWithPureObjectDefinition(item)
- ${{ text: `I would like ${item} today`}}

# StringTemplateWithObjectDefinition(item)
- get 'text' value : ${{ text: `I would like ${item} today`}.text}

# StringTemplateWithPureArrayDefinition(item)
- ${[`I would like ${item} today`]}

# StringTemplateWithArrayDefinition(item)
- get first value : ${[`I would like ${item} today`][0]}

@Danieladu Danieladu requested review from a team as code owners May 19, 2021 02:34
@Danieladu Danieladu requested review from tomlm and luhan2017 May 19, 2021 02:34
@coveralls
Copy link

coveralls commented May 19, 2021

Pull Request Test Coverage Report for Build 855389886

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 85.451%

Totals Coverage Status
Change from base Build 854509461: -0.003%
Covered Lines: 19236
Relevant Lines: 21414

💛 - Coveralls

@joshgummersall joshgummersall merged commit ae3ec20 into main May 19, 2021
@joshgummersall joshgummersall deleted the hond/support-strinte-in-object branch May 19, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Allow back quotes in adaptive expression object and array construction (#5588)
3 participants