chore: Replace catch with assert.rejects|throws in tests (part 2)

[mdrichardson]

Partially addresses: #3426
#minor

Description

We has some awkward usage of

try {
  methodThatShouldFail()
  assert.fail('not whatever')
} catch (err) {
	assert.strictEqual(err.message, 'whatever');
}

That I converted to

assert.throws(
	() => methodThatShouldFail(),
	Error('whatever')
);

Note

There's a commit with a bunch of no-op linting fixes. I recommend mostly reviewing the other one.

[coveralls]

Pull Request Test Coverage Report for Build 817416466

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+1.06%) to 85.434%

---

Totals
Change from base Build 817396671:	1.06%
Covered Lines:	19225
Relevant Lines:	21402

---

💛 - Coveralls