Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: conflict -> precondition failed #3645

Merged
merged 1 commit into from
May 3, 2021
Merged

fix: conflict -> precondition failed #3645

merged 1 commit into from
May 3, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3644

@joshgummersall joshgummersall requested review from a team as code owners May 3, 2021 16:48
@coveralls
Copy link

coveralls commented May 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 807474412

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 85.432%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/input/oauthInput.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 801262478: -0.003%
Covered Lines: 19218
Relevant Lines: 21395
💛 - Coveralls

@stevengum stevengum merged commit fa6581d into main May 3, 2021
@stevengum stevengum deleted the jpg/fix-precondition-failed-status branch May 3, 2021 18:00
joshgummersall added a commit that referenced this pull request May 10, 2021
@joshgummersall
fix: conflict -> precondition failed (#3645)
963c22a 
Fixes #3644
stevengum added a commit that referenced this pull request May 10, 2021
@joshgummersall @Danieladu @stevengum
cherrypick: 4.13.2 patch changes (#3667)
68bb7a6 
* fix: conflict -> precondition failed (#3645)

Fixes #3644

* Support timestamp without timezone postfix in getTimeOfDay (#3639)

* fix: add @types/express (#3652)

Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>

* fix: config file overrides (#3660)

Fixes #3659

* fix: add msbot keywords to component packages (#3657)

Fixes #3656

* port: telemetry pii settings path (#3665)

Fixes #3663

Co-authored-by: Hongyang Du (hond) <hond@microsoft.com>
Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricDahlvang EricDahlvang EricDahlvang approved these changes

@stevengum stevengum stevengum approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: oauth input returns conflict for consent required
4 participants
@joshgummersall @coveralls @EricDahlvang @stevengum