Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix subArray and substring while index equals the length of array/string #3637

Merged
merged 4 commits into from
May 6, 2021

Conversation

Danieladu
Copy link
Contributor

@Danieladu Danieladu commented Apr 28, 2021

Fixes #3616

Description

It should be valid in function subArray and substring while index equals to the length of Array/String.
For example:
subArray([1], 1, 1) should return []
substring('ab', 2, 0) should return empty string

Tag: The substring part should be port to C#

@Danieladu Danieladu changed the title Fix subArray and substring while index equals the length of array/string fix: Fix subArray and substring while index equals the length of array/string Apr 28, 2021
@Danieladu Danieladu requested a review from chrimc62 April 28, 2021 02:48
@coveralls
Copy link

coveralls commented Apr 28, 2021

Pull Request Test Coverage Report for Build 815441815

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 85.434%

Totals Coverage Status
Change from base Build 811247959: -0.003%
Covered Lines: 19217
Relevant Lines: 21393

💛 - Coveralls

@joshgummersall
Copy link
Contributor

@Danieladu what's the status of this?

@Danieladu Danieladu marked this pull request as ready for review May 6, 2021 02:40
@Danieladu Danieladu requested review from a team as code owners May 6, 2021 02:40
@Danieladu Danieladu requested a review from Stevenic May 6, 2021 02:40
@Danieladu Danieladu merged commit 84748d4 into main May 6, 2021
@Danieladu Danieladu deleted the hond/fix-subArray branch May 6, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subArray([0], 1, 0) should not return an error
3 participants