port: settings memory scope #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 742967829
💛 - Coveralls |
stevengum
approved these changes
Apr 12, 2021
joshgummersall
added a commit
that referenced
this pull request
Apr 22, 2021
* fix: reorganize dialog test structure * fix: refactor dialog memory tests * port: settings memory scope initial settings Fixes #3461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3461
For review, the first two commits reorganize and refactor memory-related tests in
botbuilder-dialogs. The third commit is the meat of the port. Feel free to glance over the first two commits as they don't introduce any new behavior. The third commit warrants a closer review.