feat: add updated auth code for CloudAdapter #3534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengum
commented
Apr 6, 2021
Comment on lines
65
to
84
| // TODO: Update docstring - this is a direct port from .NET | ||
| /** | ||
| * Authenticate Bot Framework Protocol request to Skills. | ||
| * | ||
| * @param authHeader The HTTP auth header in the skill request. | ||
| */ | ||
| authenticateChannelRequest(authHeader: string): Promise<ClaimsIdentity> { |
Member
Author
There was a problem hiding this comment.
authenticateChannelServiceRequest might have been more accurate, albeit tied to a concept from different layer; botbuilder-core/Microsoft.Bot.Builder and botbuilder/Microsoft.Bot.Builder.Integration.AspNet.Core
stevengum
commented
Apr 6, 2021
libraries/botframework-connector/tests/auth/userTokenClient.test.js
Outdated
Show resolved
Hide resolved
libraries/botframework-connector/tests/auth/userTokenClient.test.js
Outdated
Show resolved
Hide resolved
libraries/botframework-connector/tests/auth/userTokenClient.test.js
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 801016899
💛 - Coveralls |
libraries/botframework-connector/src/auth/userTokenClientImpl.ts
Outdated
Show resolved
Hide resolved
libraries/botframework-connector/src/auth/botFrameworkAuthentication.ts
Outdated
Show resolved
Hide resolved
stevengum
force-pushed
the
stgum/bfAuth
branch
2 times, most recently
from
1f4047f to
178d0e5
Compare
libraries/botframework-connector/src/auth/botFrameworkAuthentication.ts
Outdated
Show resolved
Hide resolved
* add UserTokenClient, ConnectorFactory, BotFrameworkAuthentication * move InvokeResponse to schema * move BotFrameworkClient to connector * add stdlib to connector * auto-fix lint errors in connector * changed activityEx.getConversationReference return type
* address PR feedback * revert changes to unused enterpriseChannelValidation.ts
joshgummersall
approved these changes
Apr 30, 2021
libraries/botframework-connector/src/auth/serviceClientCredentialsFactory.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3533 work
#minor
Specific Changes
BotFrameworkAuthentication,ConnectorFactory,UserTokenClient,UserTokenClientImplInvokeResponseto botframework-schemaBotFrameworkClientto botframework-connectoractivityEx.getConversationReferencereturn type toConversationReferenceConversationReference, so changing fromPartial<ConversationReference>toConversationReferenceisn't a breaking change in implementation or semantics.Testing
Added unit tests for tests
UserTokenClient