Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve bad runtime adapter/skill auth configuration #3499

Merged
merged 3 commits into from
Mar 31, 2021
Merged

fix: resolve bad runtime adapter/skill auth configuration #3499

merged 3 commits into from
Mar 31, 2021

Conversation

joshgummersall
Copy link
Contributor

Couple oversights:

  • Hard coded dummy appId/appPassword for Skills
  • Mis-port of CoreBotAdapter due to differences between .NET CloudAdapter and JS BotFrameworkAdapter

@joshgummersall joshgummersall requested review from a team as code owners March 31, 2021 18:25
@coveralls
Copy link

coveralls commented Mar 31, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 706051109

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 84.95%
Totals Coverage Status
Change from base Build 702794866: -0.3%
Covered Lines: 18898
Relevant Lines: 21184
💛 - Coveralls

@joshgummersall joshgummersall merged commit 9a6d8eb into main Mar 31, 2021
@joshgummersall joshgummersall deleted the jpg/runtime-bot-framework-adapter-configuration branch March 31, 2021 19:21
joshgummersall added a commit that referenced this pull request Mar 31, 2021
@joshgummersall
fix: resolve bad runtime adapter/skill auth configuration (#3499)
23edb76 
* fix: resolve bad runtime adapter/skill auth configuration

* fix: lint, PR suggestions

* fix: typo
joshgummersall added a commit that referenced this pull request Mar 31, 2021
@joshgummersall
fix: resolve bad runtime adapter/skill auth configuration (#3499) (#3504
756b85f 
)

* fix: resolve bad runtime adapter/skill auth configuration

* fix: lint, PR suggestions

* fix: typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@chrimc62 chrimc62 Awaiting requested review from chrimc62

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshgummersall @coveralls @stevengum