Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getSuggestionsCard() to set card title #3488

Merged
merged 1 commit into from
Mar 30, 2021
Merged

fix: getSuggestionsCard() to set card title #3488

merged 1 commit into from
Mar 30, 2021

Conversation

stevengum
Copy link
Member

Fixes #3431

Description

This PR fixes QnACardBuilder.getSuggestionsCard() to correctly use QnAMakerDialog.activeLearningCardTitle as expected.

Specific Changes

  • Fix call to CardFactory.heroCard() in QnACardBuilder.getSuggestionsCard()

Testing

Add unit test coverage for fix.

@stevengum stevengum requested review from a team as code owners March 30, 2021 16:14
@stevengum stevengum merged commit 7163531 into main Mar 30, 2021
@stevengum stevengum deleted the stgum/3431 branch March 30, 2021 16:31
@coveralls
Copy link

coveralls commented Mar 30, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 702082345

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-8.0%) to 84.947%
Totals Coverage Status
Change from base Build 702056310: -8.0%
Covered Lines: 18898
Relevant Lines: 21184
💛 - Coveralls

joshgummersall pushed a commit that referenced this pull request Mar 30, 2021
@stevengum
fix: getSuggestionsCard() to set card title (#3488)
7528841
joshgummersall added a commit that referenced this pull request Mar 30, 2021
@joshgummersall @stevengum
cherrypick: semver, qna fixes (#3491)
d4f6d2a 
* fix: getSuggestionsCard() to set card title (#3488)

* fix: semver formatting (#3490)

Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>

Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QNA Maker Dialog Active Learning title is not being set to value passed in
3 participants
@stevengum @coveralls @joshgummersall