Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename runtime packages #3481

Merged
merged 2 commits into from
Mar 29, 2021
Merged

fix: rename runtime packages #3481

merged 2 commits into from
Mar 29, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3480

Reconciles naming around botbuilder-dialogs-adaptive-runtime prefix, as per .NET SDK.

@joshgummersall joshgummersall requested review from stevengum and a team as code owners March 29, 2021 22:40
@coveralls
Copy link

coveralls commented Mar 29, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 699475553

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 84.906%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 699443135: 0.0%
Covered Lines: 18876
Relevant Lines: 21167
💛 - Coveralls

@stevengum stevengum merged commit ca261db into main Mar 29, 2021
@stevengum stevengum deleted the jpg/runtime-naming-fixes branch March 29, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Runtime: Rename assembly to Microsoft.Bot.Builder.Dialogs.Adaptive.Runtime (#5386)
3 participants
@joshgummersall @coveralls @stevengum