Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: component registration -> bot components #3471

Merged
merged 18 commits into from
Mar 29, 2021
Merged

Conversation

joshgummersall
Copy link
Contributor

Fixes the bulk of #3453

  • Make service construction sync to better interop with existing services
  • Move to Bot Components instead of ComponentRegistration

@joshgummersall joshgummersall force-pushed the jpg/runtime-service-collection-refactor branch from a49837a to e8c3579 Compare March 26, 2021 22:13
@joshgummersall joshgummersall marked this pull request as ready for review March 26, 2021 22:17
@joshgummersall joshgummersall requested review from stevengum and a team as code owners March 26, 2021 22:17
@joshgummersall joshgummersall requested review from Stevenic and removed request for a team March 26, 2021 22:17
@joshgummersall joshgummersall changed the base branch from jpg/runtime-service-collection-refactor to main March 26, 2021 22:17
@joshgummersall joshgummersall marked this pull request as draft March 26, 2021 22:17
@joshgummersall joshgummersall marked this pull request as ready for review March 26, 2021 22:45
@coveralls
Copy link

coveralls commented Mar 27, 2021

Pull Request Test Coverage Report for Build 699365234

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.1%) to 84.9%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-core/src/botComponent.ts 1 60.0%
libraries/botbuilder-dialogs-declarative/src/componentDeclarativeTypes.ts 1 40.0%
libraries/botbuilder-dialogs/src/memory/scopes/settingsMemoryScope.ts 1 92.86%
libraries/botbuilder-ai/src/luisComponentRegistration.ts 4 50.0%
libraries/botbuilder-ai/src/qnaMakerComponentRegistration.ts 4 50.0%
libraries/botbuilder-dialogs-declarative/src/resources/resourceExplorer.ts 6 86.98%
libraries/botbuilder-dialogs/src/memory/dialogStateManager.ts 10 95.05%
Totals Coverage Status
Change from base Build 698291503: -0.1%
Covered Lines: 18876
Relevant Lines: 21167

💛 - Coveralls

@stevengum stevengum merged commit 85ff1fe into main Mar 29, 2021
@stevengum stevengum deleted the jpg/runtime-overhaul branch March 29, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants