Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Assign a default TemplateEngineLanguageGenerator to Generator #3444

Merged
merged 5 commits into from
Mar 26, 2021
Merged

port: Assign a default TemplateEngineLanguageGenerator to Generator #3444

merged 5 commits into from
Mar 26, 2021

Conversation

Danieladu
Copy link
Contributor

@Danieladu Danieladu commented Mar 25, 2021 •
edited by joshgummersall
Loading

Fixes #3439

@Danieladu Danieladu requested review from a team as code owners March 25, 2021 09:24
@coveralls
Copy link

coveralls commented Mar 25, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 688491005

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.0009%) to 84.979%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive/src/templates/activityTemplate.ts 2 84.0%
libraries/botbuilder-dialogs-adaptive/src/templates/textTemplate.ts 2 80.0%
Totals Coverage Status
Change from base Build 688310663: 0.0009%
Covered Lines: 18833
Relevant Lines: 21103
💛 - Coveralls

@joshgummersall joshgummersall merged commit fe7ce62 into main Mar 26, 2021
@joshgummersall joshgummersall deleted the hond/default-generator branch March 26, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Assign a default TemplateEngineLanguageGenerator to Generator (#5249)
3 participants
@Danieladu @coveralls @joshgummersall