Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Change ChoiceSet to support LG #3443

Merged
merged 8 commits into from
Mar 26, 2021
Merged

port: Change ChoiceSet to support LG #3443

merged 8 commits into from
Mar 26, 2021

Conversation

Danieladu
Copy link
Contributor

Fixes #3393

@Danieladu Danieladu requested review from chrimc62, tomlm and a team as code owners March 25, 2021 08:53
@coveralls
Copy link

coveralls commented Mar 25, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 688493267

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.03%) to 85.01%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/expressionProperties/expressionProperty.ts 1 90.41%
libraries/botbuilder-dialogs-adaptive/src/input/choiceInput.ts 1 80.36%
libraries/botbuilder-dialogs-adaptive/src/input/confirmInput.ts 1 87.25%
libraries/botbuilder-dialogs-adaptive/src/input/choiceSet.ts 5 76.09%
Totals Coverage Status
Change from base Build 688310663: 0.03%
Covered Lines: 18875
Relevant Lines: 21142
💛 - Coveralls

@joshgummersall joshgummersall merged commit 4c9120f into main Mar 26, 2021
@joshgummersall joshgummersall deleted the hond/choicetemplate branch March 26, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Change ChoiceSet to support LG (#5309)
3 participants
@Danieladu @coveralls @joshgummersall