Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better version metadata #3364

Merged
merged 1 commit into from
Mar 5, 2021
Merged

fix: better version metadata #3364

merged 1 commit into from
Mar 5, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3363

@joshgummersall joshgummersall requested a review from a team as a code owner March 5, 2021 19:06
@joshgummersall
Copy link
Contributor Author

Still need to update pipelines.

@coveralls
Copy link

coveralls commented Mar 5, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 625760473

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.884%
Totals Coverage Status
Change from base Build 625745297: 0.02%
Covered Lines: 18646
Relevant Lines: 20923
💛 - Coveralls

@joshgummersall joshgummersall force-pushed the jpg/fix-version-metadata-formatting branch from f0cab05 to eb8a840 Compare March 5, 2021 21:42
stevengum
stevengum approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@stevengum stevengum merged commit a48c0b8 into main Mar 5, 2021
@stevengum stevengum deleted the jpg/fix-version-metadata-formatting branch March 5, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: version metadata scheme can yield invalid semver
3 participants
@joshgummersall @coveralls @stevengum