Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add botbuilder-runtime-integration-express #3354

Merged
merged 7 commits into from
Mar 9, 2021
Merged

feat: add botbuilder-runtime-integration-express #3354

merged 7 commits into from
Mar 9, 2021

Conversation

stevengum
Copy link
Member

@stevengum stevengum commented Mar 2, 2021 •
edited
Loading

Fixes #3352

Description

Adds botbuilder-runtime-integration-express to enable JS Runtime bots to use express instead of restify.

Specific Changes

  • start(), makeApp(), Options` are the exports
  • index.d.ts exposes a public dependency on runtypes
    • runtypes is a new public dependency in botbuilder-runtime used for type checking at compile time and runtime.

Testing

Tested using stgum/runtime-contoso (forked from jpg/runtime-contoso)

@coveralls
Copy link

coveralls commented Mar 2, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 636255656

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 84.841%
Totals Coverage Status
Change from base Build 634365284: 0.009%
Covered Lines: 18654
Relevant Lines: 20940
💛 - Coveralls

@stevengum
Copy link
Member Author

stevengum commented Mar 2, 2021 •
edited
Loading

@stevengum Apply same feedback from #3353 (comment) Done

@stevengum stevengum marked this pull request as ready for review March 5, 2021 20:06
@stevengum stevengum requested a review from a team as a code owner March 5, 2021 20:06
joshgummersall
joshgummersall reviewed Mar 5, 2021
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid! One small comment.

libraries/botbuilder-runtime-integration-express/src/index.ts Outdated Show resolved Hide resolved
@stevengum stevengum merged commit 2eeab80 into main Mar 9, 2021
@stevengum stevengum deleted the stgum/3352 branch March 9, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add botbuilder-runtime-integration-express library
3 participants
@stevengum @coveralls @joshgummersall