Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: QnAMakerDialog to handle interuption scenarios #3346

Merged
merged 12 commits into from
Mar 2, 2021
Merged

fix: QnAMakerDialog to handle interuption scenarios #3346

merged 12 commits into from
Mar 2, 2021

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Feb 26, 2021

Fixes #3345

Description

Ported latest changes of QnAMakerDialog/QnAMakerRecognizer from C#.

Specific Changes

  • New interface QnAMakerClient
  • New turn state key QnAMakerClientKey
  • Added continueDialog and onPreBubbleEvent to QnAMakerDialog
  • Added fillRecognizerResultTelemetryProperties to QnAMakerRecognizer
  • Updated access modifiers

Testing

Updated corresponding tests.

@chon219 chon219 added the Area: AI-QnAMaker The issue is related to QnA Maker label Feb 26, 2021
@chon219 chon219 requested review from a team as code owners February 26, 2021 10:31
joshgummersall
joshgummersall reviewed Feb 27, 2021
View reviewed changes
libraries/botbuilder-dialogs/src/recognizer.ts Outdated Show resolved Hide resolved
libraries/botbuilder-ai/src/qnaMaker.ts Outdated Show resolved Hide resolved
libraries/botbuilder-ai/src/qnaMakerDialog.ts Outdated Show resolved Hide resolved
libraries/botbuilder-ai/src/qnaMakerDialog.ts Outdated Show resolved Hide resolved
libraries/botbuilder-ai/src/qnaMakerDialog.ts Outdated Show resolved Hide resolved
libraries/botbuilder-ai/src/qnaMakerDialog.ts Outdated Show resolved Hide resolved
libraries/botbuilder-ai/src/qnaMakerRecognizer.ts Outdated Show resolved Hide resolved
libraries/botbuilder-ai/src/qnaMakerRecognizer.ts Outdated Show resolved Hide resolved
libraries/botbuilder-ai/src/qnaMakerRecognizer.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Mar 2, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 612631753

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 73 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 84.764%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-ai/src/qnaMaker.ts 1 96.18%
libraries/botbuilder-dialogs/src/recognizer.ts 3 85.11%
libraries/botbuilder-ai/src/qnaMakerRecognizer.ts 26 64.02%
libraries/botbuilder-ai/src/qnaMakerDialog.ts 43 72.79%
Totals Coverage Status
Change from base Build 594031505: 0.2%
Covered Lines: 18621
Relevant Lines: 20933
💛 - Coveralls

@chon219 chon219 merged commit 05a8f15 into main Mar 2, 2021
@chon219 chon219 deleted the zim/port-qna branch March 2, 2021 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
Area: AI-QnAMaker The issue is related to QnA Maker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PORT: Fix QnAMakerDialog to handle interuption scenarios
3 participants
@chon219 @coveralls @joshgummersall