Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade package parse-url to fix the security issue #3337

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Upgrade package parse-url to fix the security issue #3337

merged 2 commits into from
Feb 23, 2021

Conversation

Danieladu
Copy link
Contributor

Description

Package url-parser with version 1.5.0 has a security issue.
Upgrade to 1.5.1

Reference: https://nvd.nist.gov/vuln/detail/CVE-2021-27515

@coveralls
Copy link

coveralls commented Feb 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 593994083

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 84.885%
Totals Coverage Status
Change from base Build 585712775: 0.05%
Covered Lines: 18590
Relevant Lines: 20883
💛 - Coveralls

@joshgummersall
Copy link
Contributor

@Danieladu I reverted changes to private (unpublished) packages to unblock the tests. We can upgrade those packages one the streaming E2E test is working again.

@joshgummersall joshgummersall merged commit 875d1f7 into main Feb 23, 2021
@joshgummersall joshgummersall deleted the hond/upgrade-url-parse branch February 23, 2021 22:07
joshgummersall pushed a commit that referenced this pull request Feb 23, 2021
@Danieladu
Upgrade package parse-url to fix the security issue (#3337)
c5e5fe3 
* update package parse-url

* Revert changes to private packages

Co-authored-by: Josh Gummersall <jgummersall@microsoft.com>
@joshgummersall joshgummersall mentioned this pull request Feb 23, 2021
Merged
joshgummersall added a commit that referenced this pull request Feb 23, 2021
@joshgummersall @Danieladu
Upgrade package parse-url to fix the security issue (#3337) (#3338)
8f903a6 
* update package parse-url

* Revert changes to private packages

Co-authored-by: Josh Gummersall <jgummersall@microsoft.com>

Co-authored-by: Hongyang Du (hond) <hond@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Danieladu @coveralls @joshgummersall