Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter out undefined regex match groups #3335

Merged
merged 2 commits into from
Feb 21, 2021
Merged

fix: filter out undefined regex match groups #3335

merged 2 commits into from
Feb 21, 2021

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Feb 20, 2021

Description

The value of a regex matched group could be undefined in JavaScript. We have to filter these values out.

Specific Changes

  • RegexRecognizer

Testing

Added test.

@chon219 chon219 added the Area: Adaptive The issue is related to Adaptive dialogs label Feb 20, 2021
@chon219 chon219 requested review from a team as code owners February 20, 2021 15:07
@coveralls
Copy link

coveralls commented Feb 20, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 584442337

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0005%) to 84.882%
Totals Coverage Status
Change from base Build 581943627: 0.0005%
Covered Lines: 18590
Relevant Lines: 20883
💛 - Coveralls

@chon219 chon219 merged commit 97c8a88 into main Feb 21, 2021
@chon219 chon219 deleted the zim/fix-regex-group-undefined branch February 21, 2021 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
Area: Adaptive The issue is related to Adaptive dialogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chon219 @coveralls @joshgummersall