[PORT]Add 'any' and 'all' prebuilt function #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 580038351
💛 - Coveralls |
joshgummersall
suggested changes
Feb 18, 2021
| @@ -420,7 +420,6 @@ const badExpressions = [ | |||
| ['where(items, item, item2, item3)', 'should have three parameters'], | |||
| ['where(items, add(1), item)', 'Second paramter of where is not an identifier'], | |||
| ['where(items, 1, item)', 'Second paramter error'], | |||
| ['where(items, x, sum(x))', 'third paramter error'], | |||
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
Currently SDK would treat the "error item" in Where iteration as a "false" result and drop it to avoid too much errors.
So where(items, x, sum(x)) is valid, but empty array would be returned.
| * @param list item list. | ||
| * @param callback call back. return the should break flag. | ||
| */ | ||
| public static lambdaEvaluator<T = unknown, U = unknown>(expression: Expression, state: MemoryInterface, options: Options, list: T[], callback: (currentItem: T, result: U, error: string) => boolean): void{ |
joshgummersall
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3303
Description
Add
anyandallprebuilt function for Collections.Examples
any(createArray(1, 'cool'), item, isInteger(item))->trueany(createArray('first', 'cool'), item => isInteger(item))->falseall(createArray(1, 'cool'), item, isInteger(item))->falseall(createArray(1, 2), item => isInteger(item))->true