Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@BKHMSI
Copy link
Contributor

@BKHMSI BKHMSI commented Jul 18, 2018

  • Translator Mocks
    • Using stubs for functions that uses api-calls in language translator unit-tests using sinon module
    • Removed translator key from language translator tests
  • Automatically Formatting Date and Time based on Locale
    • Removed hard-coded date/time format
    • Using already existing moment module to automatically format them based on locale
    • Corrected date format in locale converter test based on moment: YYYY-MM-DD => YYYY/MM/DD
    • Now time is correctly formatted according to locale

@msftclas
Copy link

msftclas commented Jul 18, 2018

CLA assistant check
All CLA requirements met.

@coveralls
Copy link

coveralls commented Jul 24, 2018

Pull Request Test Coverage Report for Build 649

  • 23 of 24 (95.83%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+7.2%) to 69.491%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-ai/src/languageTranslator.ts 16 17 94.12%
Totals Coverage Status
Change from base Build 646: 7.2%
Covered Lines: 2004
Relevant Lines: 2751

💛 - Coveralls

@BKHMSI BKHMSI changed the title Automatically Format Date and Time based on Locale Translator Mocks and Automatically Formatting Date and Time based on Locale Jul 26, 2018
@cleemullins
Copy link
Contributor

@BKHMSI A number of changes were just made in the C# version of this library to migrate it to the latest set of Translation APIs, as the current API versions are depricated. How does this change align with that?

See the C# PR here: microsoft/botbuilder-dotnet#789

Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Stevenic Stevenic merged commit 67d9713 into microsoft:master Aug 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants