Fix fetch in token server used in E2E Streaming Test #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zerryth
requested review from
joshgummersall,
stevengum and
a team
as code owners
|
cross-fetch handles the isomorphic piece so you can import and go. We should be moving to this package to keep our code more straightforward. |
…rosoft/botbuilder-js into Zerryth/streaming-test-fetch
|
cross-fetch sounds good to me! |
stevengum
approved these changes
Oct 23, 2020
Zerryth
commented
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2943
Description
Use
cross-fetchto make token request.Testing
Created a test pipeline; runs the E2E DL ASE Streaming Tests successfully.