Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: remove unnecessary verbose trace logging #2936

Merged
merged 3 commits into from
Oct 21, 2020
Merged

port: remove unnecessary verbose trace logging #2936

merged 3 commits into from
Oct 21, 2020

Conversation

joshgummersall
Copy link
Contributor

Fixes #2930

@joshgummersall joshgummersall requested a review from a team as a code owner October 21, 2020 20:36
@joshgummersall joshgummersall changed the title Remove unnecessary verbose trace logging port: remove unnecessary verbose trace logging Oct 21, 2020
stevengum
stevengum approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshgummersall joshgummersall merged commit 4357233 into main Oct 21, 2020
@joshgummersall joshgummersall deleted the jpg/remove-skill-dialog-traces branch October 21, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricDahlvang EricDahlvang EricDahlvang approved these changes

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PORT: The SDK is over-verbose in generating TraceActivity records and it can't be turned off.
3 participants
@joshgummersall @EricDahlvang @stevengum