Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSDoc] Add missing documentation for botbuilder-dialogs-adaptive entityRecognizers folder #2915

Conversation

denscollo
Copy link
Contributor

Addresses #2602

Description

This PR adds all the missing JSDoc documentation for botbuilder-dialogs-adaptive based on the errors thrown. Some documentation is ported and adapted from botbuilder-dotnet

Specific Changes

  • Ported documentation from botbuilder-dotnet
  • Added documentation for the files inside recognizers/entityRecognizers folder.
  • Added @protected for protected methods.
  • Added JSDoc comments in 20 files.

Testing

In the following image there is a sneak peek about the ESLint Report with no JSDoc errors.
image

@denscollo denscollo requested a review from a team as a code owner October 19, 2020 17:40
@joshgummersall joshgummersall merged commit 8ed9807 into microsoft:main Oct 19, 2020
@denscollo denscollo deleted the southworks/add/jsdoc/botbuilder-dialogs-adaptive/recognizers-entityRecognizers branch October 19, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants