Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Improvements around runtime coverage, code coverage reports and add GitHub workflows #2868

Merged
merged 5 commits into from
Oct 5, 2020
Merged

CI Improvements around runtime coverage, code coverage reports and add GitHub workflows #2868

merged 5 commits into from
Oct 5, 2020

Conversation

stevengum
Copy link
Member

@stevengum stevengum commented Oct 5, 2020 •
edited
Loading

Fixes #1320
Fixes #1480

Specific Changes

  • Enable CI for Node 14 (runs after Node 10)
  • refactor primary CI pipeline to run tests for Node 10, 12, 14
  • add configuration for eslint workflow (GitHub action) to run for pushes and PRs against main and 4.10 branches
    • remove Code Analysis job from ADO pipelines to free up ADO resources
  • publish code coverage report using cobertura plugins to ADO

@stevengum stevengum requested a review from a team as a code owner October 5, 2020 02:09
@joshgummersall
Copy link
Contributor

@stevengum it seems like something went wrong when running CI for Node 10?

https://fuselabs.visualstudio.com/SDK_v4/_build/results?buildId=171919&view=logs&j=8dba71ff-8d21-5117-bd98-a4eaa8d2e2df&t=0c980d1e-7b7c-5b46-80d6-e16ed94e6c6d

@stevengum stevengum mentioned this pull request Oct 5, 2020
Closed
@stevengum
Copy link
Member Author

@joshgummersall it may have been a one-off... On the current build it passed that step without issue: https://fuselabs.visualstudio.com/SDK_v4/_build/results?buildId=172059&view=logs&j=8dba71ff-8d21-5117-bd98-a4eaa8d2e2df&t=0c980d1e-7b7c-5b46-80d6-e16ed94e6c6d

joshgummersall
joshgummersall approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@stevengum stevengum merged commit 6ebb785 into main Oct 5, 2020
@stevengum stevengum deleted the stgum/ci branch October 5, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@stevengum @joshgummersall