Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Change error messages in pre-built functions to make the descriptions more accurate #2768

Merged
merged 6 commits into from
Sep 15, 2020

Conversation

cosmicshuai
Copy link
Contributor

fixes: #2296
replace $"{expr} can't evaluate." with more detailed messages based on the context of some pre-built functions

@cosmicshuai cosmicshuai requested a review from a team as a code owner September 4, 2020 06:41
@coveralls
Copy link

coveralls commented Sep 4, 2020

Pull Request Test Coverage Report for Build 166404

  • 8 of 17 (47.06%) changed or added relevant lines in 17 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 83.233%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/adaptive-expressions/src/builtinFunctions/addToTime.ts 0 1 0.0%
libraries/adaptive-expressions/src/builtinFunctions/convertFromUTC.ts 0 1 0.0%
libraries/adaptive-expressions/src/builtinFunctions/convertToUTC.ts 0 1 0.0%
libraries/adaptive-expressions/src/builtinFunctions/startOfDay.ts 0 1 0.0%
libraries/adaptive-expressions/src/builtinFunctions/startOfHour.ts 0 1 0.0%
libraries/adaptive-expressions/src/builtinFunctions/startOfMonth.ts 0 1 0.0%
libraries/adaptive-expressions/src/builtinFunctions/ticks.ts 0 1 0.0%
libraries/adaptive-expressions/src/builtinFunctions/uriHost.ts 0 1 0.0%
libraries/adaptive-expressions/src/builtinFunctions/uriPath.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 81.55%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 166242: -0.06%
Covered Lines: 15405
Relevant Lines: 17599

💛 - Coveralls

Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cosmicshuai cosmicshuai merged commit 26b4b6b into master Sep 15, 2020
@cosmicshuai cosmicshuai deleted the shuwan/changeErrorMsg branch September 15, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] Change error messages in pre-built functions to make the descriptions more accurate
4 participants