Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port] Support create object with multi lines in LG #2756

Merged
merged 5 commits into from
Sep 2, 2020

Conversation

cosmicshuai
Copy link
Contributor

With the support of multi lines object creation,

#ctobj
- ${{a: 1, c
:3,
b:2
}}

will return {a:1, c:3, b: 2}

#evalMultiLineObj
- ${string(
setProperty(
{a: 1, 
b: 2},
'c', 
{d: 4, 
e: 5})
)}

will return" {'a':1,'b':2,'c':{'d':4,'e':5}}"

@coveralls
Copy link

coveralls commented Sep 1, 2020

Pull Request Test Coverage Report for Build 162895

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 82.966%

Totals Coverage Status
Change from base Build 162891: 0.07%
Covered Lines: 15177
Relevant Lines: 17405

💛 - Coveralls

@chrimc62
Copy link
Contributor

chrimc62 commented Sep 1, 2020

  "\x1Ck\x02\x1Dm\x02\x1Eo\x02\x1Fq\x02 s\x02!u\x02\"w\x02#\x07\x02\x03\x04" +

Should this file be check-in since it is generated?


Refers to: libraries/botbuilder-lg/src/generated/LGTemplateLexer.ts:611 in 9fc4bc5. [](commit_id = 9fc4bc5, deletion_comment = False)

Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cosmicshuai cosmicshuai changed the title Support create object with multi lines in LG [Port] Support create object with multi lines in LG Sep 2, 2020
@boydc2014
Copy link
Contributor

  "\x1Ck\x02\x1Dm\x02\x1Eo\x02\x1Fq\x02 s\x02!u\x02\"w\x02#\x07\x02\x03\x04" +

Should this file be check-in since it is generated?

Refers to: libraries/botbuilder-lg/src/generated/LGTemplateLexer.ts:611 in 9fc4bc5. [](commit_id = 9fc4bc5, deletion_comment = False)

In C# we don't have to check in this file, because vs support an explicit step of "code generation", but in js, we don't have the native support for this, so it's recommended to check in this. We placed it under a "generated" folder to distinguish with other files.

@cosmicshuai cosmicshuai merged commit 1cd8aca into master Sep 2, 2020
@cosmicshuai cosmicshuai deleted the shuwan/fixObjCreateML branch September 2, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants