Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ignoring new line characters in string interpolation #2754

Merged
merged 7 commits into from
Sep 2, 2020

Conversation

cosmicshuai
Copy link
Contributor

@cosmicshuai cosmicshuai commented Aug 31, 2020

fixes: microsoft/botbuilder-dotnet#4547

now string interpolation in adaptive expressions:

'`${hello} \n\n ${world}`'

will return:

"hello 

  world"

@cosmicshuai cosmicshuai requested a review from a team as a code owner August 31, 2020 10:16
@coveralls
Copy link

coveralls commented Aug 31, 2020

Pull Request Test Coverage Report for Build 162888

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 82.901%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 162883: -0.07%
Covered Lines: 15168
Relevant Lines: 17405

💛 - Coveralls

@cosmicshuai cosmicshuai merged commit efff875 into master Sep 2, 2020
@cosmicshuai cosmicshuai deleted the shuwan/fixNLinStrIntep branch September 2, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multi-line string in string interpolation
3 participants