Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set WaterfallStepContext.Parent correctly #2728

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Set WaterfallStepContext.Parent correctly #2728

merged 1 commit into from
Aug 19, 2020

Conversation

EricDahlvang
Copy link
Member

Fixes #2714

@EricDahlvang EricDahlvang requested a review from a team as a code owner August 19, 2020 21:01
Stevenic
Stevenic approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stevengum
Copy link
Member

Corrects WaterfallStepContext.parent change in #2480
JS Tracking issue for 2480: #2162

Original .NET issue: microsoft/botbuilder-dotnet#3854
.NET PR: microsoft/botbuilder-dotnet#3855

@coveralls
Copy link

coveralls commented Aug 19, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 158731

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 82.808%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 158344: -0.05%
Covered Lines: 15143
Relevant Lines: 17390
💛 - Coveralls

@EricDahlvang EricDahlvang merged commit 8238ab6 into master Aug 19, 2020
@EricDahlvang EricDahlvang deleted the eric/fixWaterfallStepContextParent branch August 19, 2020 21:18
EricDahlvang added a commit that referenced this pull request Aug 19, 2020
@EricDahlvang
Set WaterfallStepContext.Parent correctly (#2728)
8e006ec
cleemullins pushed a commit that referenced this pull request Aug 20, 2020
@EricDahlvang
Set WaterfallStepContext.Parent correctly (#2728) (#2729)
156a138
@EricDahlvang EricDahlvang mentioned this pull request Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stevenic Stevenic Stevenic approved these changes

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@EricDahlvang @stevengum @coveralls @Stevenic