[PORT] Pass Locale info from Activity to Adaptive-Expression and support locale in formatNumber prebuilt functions #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicshuai
requested review from
carlosscastro,
johnataylor,
stevengum,
Stevenic and
a team
as code owners
Pull Request Test Coverage Report for Build 168327
💛 - Coveralls |
|
LGTM, i modified some description to highlight the known issue. |
boydc2014
approved these changes
Aug 12, 2020
boydc2014
changed the title
boydc2014
reviewed
Aug 12, 2020
boydc2014
reviewed
Aug 12, 2020
…-js into shuwan/reworkLocale
EricDahlvang
suggested changes
Aug 12, 2020
libraries/adaptive-expressions/src/builtinFunctions/formatNumber.ts
Outdated
Show resolved
Hide resolved
|
I don't think we're quite ready to take this. Checked w/ @EricDahlvang and @carlosscastro and we'll push this issue and related PR to R11. |
joshgummersall
suggested changes
Oct 2, 2020
libraries/adaptive-expressions/src/builtinFunctions/formatNumber.ts
Outdated
Show resolved
Hide resolved
libraries/adaptive-expressions/src/builtinFunctions/formatNumber.ts
Outdated
Show resolved
Hide resolved
stevengum
approved these changes
Oct 15, 2020
joshgummersall
suggested changes
Oct 19, 2020
libraries/botbuilder-dialogs-adaptive/src/generators/templateEngineLanguageGenerator.ts
Outdated
Show resolved
Hide resolved
libraries/adaptive-expressions/src/builtinFunctions/formatNumber.ts
Outdated
Show resolved
Hide resolved
joshgummersall
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2202
closes: #2652
Locale is obtained from 'turn.activity.locale' when an incoming activity is recieved and the locale info will be set to 'turn.locale' in memory. Also user can use TurnContext.Locale to get and set locale.
After a locale is set in TurnContext. It will be passed to EvaluationOptions in TemplateEngineLanguageGenerator. Then Options in Adaptive-Expressions will be updated.
Now formatNumber prebuilt function support locale, for example:
formatNumber(12000.3, 4, "de-DE")->'12.000,3000'Note: we only make formatNumber to support locale in this PR, the other datetime and string functions need further investigations to keep the input arguments as the same as C#.
Since toLocaleString does not work correctly unless a specified nodejs version.
Moment.js only support locale like 'en', 'de' which is different from our current solution.
#2691 is tracking this issue.