Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port] properly escape slashes in constant strings with StringExpression/ValueExpression #2660

Merged
merged 4 commits into from
Aug 7, 2020
Merged

[Port] properly escape slashes in constant strings with StringExpression/ValueExpression #2660

merged 4 commits into from
Aug 7, 2020

Conversation

feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Aug 6, 2020

Fixes #2443

Description

When encoding a string as an expression we need to properly handle slash.

Specific Changes

  • AdaptiveExpressions
  • AdaptiveExpressions.Tests

Testing

tests updated to validate round-trip slashes

@feich-ms feich-ms requested a review from a team as a code owner August 6, 2020 08:53
@feich-ms feich-ms requested a review from tomlm August 6, 2020 08:53
@boydc2014 boydc2014 changed the title [C# Port]properly escape slashes in constant strings with StringExpression/ValueExpression [Port] properly escape slashes in constant strings with StringExpression/ValueExpression Aug 7, 2020
@coveralls
Copy link

coveralls commented Aug 7, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 154879

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 82.924%
Totals Coverage Status
Change from base Build 154875: 0.07%
Covered Lines: 14837
Relevant Lines: 17011
💛 - Coveralls

@feich-ms feich-ms merged commit a8b0dc9 into master Aug 7, 2020
@feich-ms feich-ms deleted the feich/fixStringExpression branch August 7, 2020 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@tomlm tomlm Awaiting requested review from tomlm

@Danieladu Danieladu Awaiting requested review from Danieladu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] properly escape slashes in constant strings with StringExpression/ValueExpression
3 participants
@feich-ms @coveralls @boydc2014