Skip to content

Declare return types in waterfallDialog.ts #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 27, 2020
Merged

Declare return types in waterfallDialog.ts #1578

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c797366
Declare return types in waterfallDialog.ts
Jan 14, 2020
d2af79d
Fix waterfall-cancel-telemetry-step-name bug
Jan 14, 2020
7b0232f
Roll back bug fix
Jan 25, 2020
9b3cd4e
Merge branch 'master' into v-kydela/waterfall
Jan 25, 2020
cd24cad
Merge branch 'master' into v-kydela/waterfall
Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions libraries/botbuilder-dialogs/src/waterfallDialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,7 @@ export class WaterfallDialog<O extends object = {}> extends Dialog<O> {
* @param instance The instance of the current dialog.
* @param reason The reason the dialog is ending.
*/
public async endDialog(context: TurnContext, instance: DialogInstance, reason: DialogReason) {

public async endDialog(context: TurnContext, instance: DialogInstance, reason: DialogReason): Promise<void> {
const state: WaterfallDialogState = instance.state as WaterfallDialogState;
const instanceId = state.values['instanceId'];
if (reason === DialogReason.endCalled) {
Expand All @@ -256,7 +255,7 @@ export class WaterfallDialog<O extends object = {}> extends Dialog<O> {
}
}

private waterfallStepName(index) {
private waterfallStepName(index: number): string {
// Log Waterfall Step event. Each event has a distinct name to hook up
// to the Application Insights funnel.
var stepName = '';
Expand Down Expand Up @@ -288,8 +287,8 @@ interface WaterfallDialogState {
* instances of a given waterfall dialog.
* Source: https://stackoverflow.com/questions/105034/create-guid-uuid-in-javascript
*/
function generate_guid() {
function s4() {
function generate_guid(): string {
function s4(): string {
return Math.floor((1 + Math.random()) * 0x10000)
.toString(16)
.substring(1);
Expand Down