Skip to content

Ported declarative test script from C# #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Jan 10, 2020
Merged

Ported declarative test script from C# #1483

merged 42 commits into from
Jan 10, 2020

Conversation

@chon219
Copy link
Member

@chon219 chon219 commented Dec 9, 2019 •
edited
Loading

Description

Ported declarative test script from C# for botbuilder-dialogs-adaptive

Specific Changes

  • Ported Test Script, Test Actions components as well as some declarative test scripts from C#
  • Refactored DialogStateManager to implement MemoryInterface to make evaluation working without getMemorySnapshot
  • Removed dependency to botbuilder-dialogs-adaptive in botbuilder-dialogs-declarative to align with C# implementations

Testing

@chon219 chon219 self-assigned this Dec 9, 2019
@chon219 chon219 marked this pull request as ready for review December 10, 2019 08:43
@chon219 chon219 requested a review from luhan2017 December 10, 2019 08:46
Stevenic
Stevenic reviewed Dec 16, 2019
View reviewed changes
Stevenic
Stevenic reviewed Jan 6, 2020
View reviewed changes
Stevenic
Stevenic reviewed Jan 6, 2020
View reviewed changes
Stevenic
Stevenic reviewed Jan 6, 2020
View reviewed changes
Stevenic
Stevenic reviewed Jan 6, 2020
View reviewed changes
Stevenic
Stevenic reviewed Jan 6, 2020
View reviewed changes
@Stevenic
Copy link
Contributor

Stevenic commented Jan 6, 2020

botbuilder-dialogs-adaptive

Refers to: libraries/botbuilder-dialogs-adaptive/src/recognizers/regexRecognizer.ts:2 in 6efea7b. [](commit_id = 6efea7b, deletion_comment = False)

@Stevenic
Copy link
Contributor

Stevenic commented Jan 6, 2020

All of the testing stuff should be moved out to a separate package given that it uses the file system.

@Danieladu Danieladu mentioned this pull request Jan 7, 2020
Merged
@chon219 chon219 force-pushed the zim/adaptive-tests branch from 5d08bfb to 39b56f5 Compare January 7, 2020 06:11
Stevenic
Stevenic approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Stevenic Stevenic merged commit f799b81 into 4.future Jan 10, 2020
@cleemullins cleemullins deleted the zim/adaptive-tests branch April 6, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zidaneymar zidaneymar Awaiting requested review from zidaneymar

@luhan2017 luhan2017 Awaiting requested review from luhan2017

1 more reviewer

@Stevenic Stevenic Stevenic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chon219 chon219

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chon219 @Stevenic