Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs Refactor, Fix HttpRequest, Add More Samples #1451

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

zidaneymar
Copy link
Contributor

Inputs Refactor, Fix HttpRequest, Add More Samples

Description

  1. InputsDialog two properties aligned with C#
  2. Fix HttpRequest
  3. Add More Samples

Specific Changes

Testing

headers: headers,
body: body
});
const url = stringTemplate.format(this.url, dc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const url = stringTemplate.format(this.url, dc); [](start = 8, length = 48)

This is likely a bug in the C# version of the code as well, but we need to make sure we URL encode any query string params. We should decide on a solution for both JS and C# here and fix in both.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const url = stringTemplate.format(this.url, dc); [](start = 8, length = 48)

This is likely a bug in the C# version of the code as well, but we need to make sure we URL encode any query string params. We should decide on a solution for both JS and C# here and fix in both.

Do we need to replace all string templates with expression property?

@Stevenic
Copy link
Contributor

Stevenic commented Dec 6, 2019

    return `AttachmentInput[]`;

We should include the name of the property we're bound to just to help make sure ID's are unique.


Refers to: libraries/botbuilder-dialogs-adaptive/src/input/attachmentInput.ts:47 in e9fabc0. [](commit_id = e9fabc0, deletion_comment = False)

@Stevenic
Copy link
Contributor

Stevenic commented Dec 6, 2019

    return `AttachmentInput[]`;

This should be done for all inputs.


In reply to: 562376699 [](ancestors = 562376699)


Refers to: libraries/botbuilder-dialogs-adaptive/src/input/attachmentInput.ts:47 in e9fabc0. [](commit_id = e9fabc0, deletion_comment = False)

Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Stevenic Stevenic merged commit 53ba6f5 into 4.future Dec 6, 2019
@cleemullins cleemullins deleted the qika/adaptive_fix branch April 6, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants