Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update choice prompt unit test for hero card prompt with attachment #1229

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

jspruance
Copy link

Update to unit test for sending a choice prompt styled as a hero card and an attachment.

  • Prior to this change, hero card and attachment were being sent back as two separate responses, one after another

  • After adding type: ActivityTypes.Message to the attachment, both the attachment and hero card are contained in the same response, as expected.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 81152

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 86.538%

Totals Coverage Status
Change from base Build 80976: 0.05%
Covered Lines: 4462
Relevant Lines: 4977

💛 - Coveralls

@cleemullins cleemullins merged commit 19dcb64 into master Oct 10, 2019
@cleemullins cleemullins deleted the choice-prompt-unit-test-update branch October 10, 2019 19:56
@cleemullins
Copy link
Contributor

MErged as part of the group PR review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants