Skip to content

Ran eslint on streaming extension library #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2019
Merged

Ran eslint on streaming extension library #1219

merged 3 commits into from
Oct 8, 2019

Conversation

tdurnford
Copy link
Contributor

Fixes #1129

Description

Fixed various eslint issues in BotBuilder Streaming Extensions Library.

Testing

Tests are unnecessary.

@coveralls
Copy link

coveralls commented Sep 24, 2019

Pull Request Test Coverage Report for Build 82272

  • 11 of 12 (91.67%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.229%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botframework-streaming-extensions/src/NamedPipe/NamedPipeServer.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 82168: 0.0%
Covered Lines: 4633
Relevant Lines: 5111

💛 - Coveralls

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@tdurnford tdurnford merged commit e970737 into microsoft:master Oct 8, 2019
@tdurnford tdurnford deleted the 1129 branch October 8, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streaming extension: Some files using double quotes, while most use single quotes
3 participants