Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[QnAMaker] GetAnswerRaw added #1172

Merged
cleemullins merged 3 commits into from
Sep 18, 2019
Merged

[QnAMaker] GetAnswerRaw added #1172

cleemullins merged 3 commits into from
Sep 18, 2019

Conversation

@gurvsing
Copy link
Contributor

@gurvsing gurvsing commented Sep 16, 2019

Added Active learning enabled flag support
Tests added for that.

@coveralls
Copy link

coveralls commented Sep 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 79536

  • 18 of 21 (85.71%) changed or added relevant lines in 2 files are covered.
  • 17 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 88.574%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-ai/src/qnaMaker.ts 15 16 93.75%
libraries/botbuilder-ai/src/qnamaker-utils/generateAnswerUtils.ts 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder/src/botFrameworkAdapter.ts 17 82.22%
Totals Coverage Status
Change from base Build 77828: -0.02%
Covered Lines: 4439
Relevant Lines: 4818
💛 - Coveralls

@gurvsing gurvsing mentioned this pull request Sep 17, 2019
Merged
@cleemullins cleemullins merged commit 13191e0 into master Sep 18, 2019
@cleemullins cleemullins deleted the gurvsing/alflag branch September 18, 2019 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stevengum stevengum Awaiting requested review from stevengum

@rokulka rokulka Awaiting requested review from rokulka

1 more reviewer

@cleemullins cleemullins cleemullins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gurvsing @coveralls @cleemullins