Skip to content

Webpack bundling broken #818

@ballwood

Description

@ballwood

Versions

What package version of the SDK are you using. Latest
What nodejs version are you using. 8.10.0
What browser version are you using N/A
What os are you using Linux

Describe the bug

After 4.1.7 - polyfill fixes broke webpack bundling
Commit here: a20a44c#diff-a4cb641e4ac7086ddd5b5af0968c47f4
Webpack cannot 'see' the require therefore leaves it in tries to look in node_modules

To Reproduce

Steps to reproduce the behavior:

  1. Bundle app using bot framework with webpack
  2. Run bundle (tries to load form-data from node_modules), throws module error

Expected behavior

Not to throw module error and form-data, node-fetch to be included in the bundle

Additional context

Webpack used for bundling code on lambdas due to size limit

[bug]

Metadata

Metadata

Labels

4.5P1Painful if we don't fix, won't block releasingbugIndicates an unexpected problem or an unintended behavior.triagedReviewed by the Triage Team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions