-
Notifications
You must be signed in to change notification settings - Fork 292
Closed
Labels
Area: AdaptiveThe issue is related to Adaptive dialogsThe issue is related to Adaptive dialogsP2Nice to haveNice to haveparityThe issue describes a gap in parity between two or more platforms.The issue describes a gap in parity between two or more platforms.
Description
The changes in Added AdaptiveTestingBotComponent (#5394) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.
Converted AdaptiveTestComponentRegistration to AdaptiveTestingBotComponent. Obsoleted AdaptiveTestComponentRegistration and changed to extend DeclarativeComponentRegistrationBridge.This could be cherry picked to 4.13. Required to convert old test cases using AdaptiveTestComponentRegistration and correct QnAMakerBotComponent
For QnAMakerBotComponent, the original code in QnAMakerComponentRegistration was:
/// <summary> /// Gets JsonConverters for DeclarativeTypes for QnAMaker. /// </summary> /// <param name="resourceExplorer">resourceExplorer to use for resolving references.</param> /// <param name="sourceContext">SourceContext to build debugger source map.</param> /// <returns>enumeration of json converters.</returns> public IEnumerable<JsonConverter> GetConverters(ResourceExplorer resourceExplorer, SourceContext sourceContext) { yield return new ArrayExpressionConverter<Metadata>(); yield return new ObjectExpressionConverter<QnARequestContext>(); }Change made to QnAMakerBotComponent to correct the QnARequestContext converter.
Please review and, if necessary, port the changes.
Metadata
Metadata
Assignees
Labels
Area: AdaptiveThe issue is related to Adaptive dialogsThe issue is related to Adaptive dialogsP2Nice to haveNice to haveparityThe issue describes a gap in parity between two or more platforms.The issue describes a gap in parity between two or more platforms.