Skip to content

port: Added AdaptiveTestingBotComponent (#5394) #3497

@github-actions

Description

@github-actions

The changes in Added AdaptiveTestingBotComponent (#5394) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Converted AdaptiveTestComponentRegistration to AdaptiveTestingBotComponent. Obsoleted AdaptiveTestComponentRegistration and changed to extend DeclarativeComponentRegistrationBridge.

This could be cherry picked to 4.13. Required to convert old test cases using AdaptiveTestComponentRegistration and correct QnAMakerBotComponent

For QnAMakerBotComponent, the original code in QnAMakerComponentRegistration was:

        /// <summary>
        /// Gets JsonConverters for DeclarativeTypes for QnAMaker.
        /// </summary>
        /// <param name="resourceExplorer">resourceExplorer to use for resolving references.</param>
        /// <param name="sourceContext">SourceContext to build debugger source map.</param>
        /// <returns>enumeration of json converters.</returns>
        public IEnumerable<JsonConverter> GetConverters(ResourceExplorer resourceExplorer, SourceContext sourceContext)
        {
            yield return new ArrayExpressionConverter<Metadata>();
            yield return new ObjectExpressionConverter<QnARequestContext>();
        }

Change made to QnAMakerBotComponent to correct the QnARequestContext converter.

Please review and, if necessary, port the changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: AdaptiveThe issue is related to Adaptive dialogsP2Nice to haveparityThe issue describes a gap in parity between two or more platforms.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions