Skip to content

port: OnCondition is not correctly caching expressions causing constant Expression.parse calls #3356

@chon219

Description

@chon219

microsoft/botbuilder-dotnet#4935

OnCondition.GetExpression() was caches the root expression, but all of the children which override GetExpression() were not. This means all child conditions which overrode GetExpression() were calling Expression.Parse() on EVERY call, causing us to parse and allocate Expression obejcts every time we evaluated an trigger. This creates a huge overhead for evaluating triggers.

Metadata

Metadata

Assignees

Labels

Area: AdaptiveThe issue is related to Adaptive dialogs

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions