-
Notifications
You must be signed in to change notification settings - Fork 292
Closed
Labels
Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.Required for internal Azure reporting. Do not delete. Do not change color.bugIndicates an unexpected problem or an unintended behavior.Indicates an unexpected problem or an unintended behavior.customer-replied-toIndicates that the team has replied to the issue reported by the customer. Do not delete.Indicates that the team has replied to the issue reported by the customer. Do not delete.customer-reportedIssue is created by anyone that is not a collaborator in the repository.Issue is created by anyone that is not a collaborator in the repository.
Description
Describe the bug
The class QnAMakerDialog is missing the logPersonalInformation flag which is present in C#. This causes, among other things, issues with telemetry reporting in Power BI.
The flag, in turn, is not being passed by constructor to QnAMaker in the method getQnAClient, unlike the behavior in C#.
Expected behavior
The class QnAMaker should have parity with C#, and telemetry should be being reported.
Additional context
- This problem was reported in a comment of issue Dialog context not showing up in Power Bi report botframework-solutions#3612.
- This is the PR where the logPersonalInformation property and other telemetry changes were added in C#
stevengum
Metadata
Metadata
Assignees
Labels
Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.Required for internal Azure reporting. Do not delete. Do not change color.bugIndicates an unexpected problem or an unintended behavior.Indicates an unexpected problem or an unintended behavior.customer-replied-toIndicates that the team has replied to the issue reported by the customer. Do not delete.Indicates that the team has replied to the issue reported by the customer. Do not delete.customer-reportedIssue is created by anyone that is not a collaborator in the repository.Issue is created by anyone that is not a collaborator in the repository.

