fix: Remove request package from botbuilder-core tests (#4514)

* Replace request with axios in bb-core tests * Include axios in package.json
microsoft · Aug 7, 2023 · e51063d · e51063d
1 parent e402eca
commit e51063d
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 29 deletions.
diff --git a/libraries/botbuilder-core/package.json b/libraries/botbuilder-core/package.json
@@ -35,8 +35,8 @@
     "zod": "~1.11.17"
   },
   "devDependencies": {
+    "axios": "^0.25.0",
     "chatdown": "^1.2.4",
-    "request": "^2.88.2",
     "unzipper": "^0.10.9"
   },
   "scripts": {

diff --git a/libraries/botbuilder-core/tests/transcriptUtilities.js b/libraries/botbuilder-core/tests/transcriptUtilities.js
@@ -9,7 +9,7 @@ const path = require('path');
 const url = require('url');
 const promisify = require('util').promisify;
 const readFileAsync = promisify(fs.readFile);
-const request = require('request');
+const axios = require('axios');
 const unzip = require('unzipper');
 const rimraf = require('rimraf');
 
@@ -138,33 +138,37 @@ function downloadAndExtractOnce(url) {
                 const writeStream = fs.createWriteStream(zipPath);
 
                 // download
-                request
-                    .get(url)
-                    .on('end', function () {
-                        // unzip
-                        console.log(`\tUnzipping ${zipPath} into ${outputPath}`);
-                        decompressZip(zipPath, outputPath, function (unzipErr) {
-                            fs.unlinkSync(zipPath); // delete zip
-                            if (unzipErr) {
-                                // error while extracting
-                                return reject(unzipErr);
-                            }
-
-                            // get branch's inner folder
-                            const childDirectories = getDirectories(outputPath);
-                            let firstDirectory = childDirectories[0];
-                            if (!firstDirectory) {
-                                return reject('Downloaded ZIP did not contain a branch folder.');
-                            }
-
-                            firstDirectory = path.join(firstDirectory, zipTranscriptsRelativePath);
-
-                            console.log(`\tTranscripts extracted at ${firstDirectory}`);
-                            return resolve(firstDirectory);
-                        });
+                axios
+                    .get(url, { responseType: 'stream' })
+                    .then((response) => {
+                        response.data
+                            .on('end', function () {
+                                // unzip
+                                console.log(`\tUnzipping ${zipPath} into ${outputPath}`);
+                                decompressZip(zipPath, outputPath, function (unzipErr) {
+                                    fs.unlinkSync(zipPath); // delete zip
+                                    if (unzipErr) {
+                                        // error while extracting
+                                        return reject(unzipErr);
+                                    }
+
+                                    // get branch's inner folder
+                                    const childDirectories = getDirectories(outputPath);
+                                    let firstDirectory = childDirectories[0];
+                                    if (!firstDirectory) {
+                                        return reject('Downloaded ZIP did not contain a branch folder.');
+                                    }
+
+                                    firstDirectory = path.join(firstDirectory, zipTranscriptsRelativePath);
+
+                                    console.log(`\tTranscripts extracted at ${firstDirectory}`);
+                                    return resolve(firstDirectory);
+                                });
+                            })
+                            .on('error', (e) => reject(e)) // reject on download error
+                            .pipe(writeStream);
                     })
-                    .on('error', (e) => reject(e)) // reject on download error
-                    .pipe(writeStream);
+                    .catch((e) => reject(e));
             });
         });
     }

diff --git a/yarn.lock b/yarn.lock
@@ -10998,7 +10998,7 @@ request-promise-native@^1.0.5:
     stealthy-require "^1.1.1"
     tough-cookie "^2.3.3"
 
-request@^2.88.0, request@^2.88.2:
+request@^2.88.0:
   version "2.88.2"
   resolved "https://registry.yarnpkg.com/request/-/request-2.88.2.tgz#d73c918731cb5a87da047e207234146f664d12b3"
   integrity sha512-MsvtOrfG9ZcrOwAW+Qi+F6HbD0CWXEh9ou77uOb7FM2WPhwT7smM833PzanhJLsgXjN89Ir6V2PczXNnMpwKhw==