Skip to content

Commit

Permalink
hotfix: add botbuilder-stdlib package.json reference
Browse files Browse the repository at this point in the history
  • Loading branch information
Josh Gummersall committed Feb 18, 2021
1 parent 21510a0 commit 9c743d9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions libraries/botbuilder-dialogs-declarative/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"dependencies": {
"botbuilder-core": "4.1.6",
"botbuilder-dialogs": "4.1.6",
"botbuilder-stdlib": "4.1.6",
"chokidar": "^3.4.0",
"jsonpath": "^1.0.0"
},
Expand Down

2 comments on commit 9c743d9

@compulim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshgummersall do you have a pull request attached to this issue? I would like to know what this commit would fix.

@joshgummersall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@compulim apologies, as this was a quick hotfix I did not create a full pull request. A consumer that runs npm install botbuilder-dialogs-declarative in isolation would download both this package and all its dependencies. In the code that comprises this package, a file imports code from botbuilder-stdlib. This works in our monorepo due to hoisting but would fail for the consumer as they would not have a copy of the botbuilder-stdlib package.

Please sign in to comment.