mostly final changes before pr

microsoft · Feb 19, 2020 · 433199b · 433199b
1 parent b8b0ab1
commit 433199b
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/libraries/botbuilder-core/src/activityHandler.ts b/libraries/botbuilder-core/src/activityHandler.ts
@@ -250,6 +250,18 @@ export class ActivityHandler extends ActivityHandlerBase {
         return this.on('Event', handler);
     }
 
+    /**
+     * Registers an activity event handler for the _invoke_ event, emitted for every incoming event activity.
+     * 
+     * @param handler The event handler.
+     * 
+     * @remarks
+     * Returns a reference to the [ActivityHandler](xref:botbuilder-core.ActivityHandler) object.
+     * 
+     * To handle a `signin/verifyState` invoke event or `signin/tokenExchange`, use the
+     * [onInvokeActivity](xref:botbuilder-core.ActivityHandler.onInvokeActivity) sub-type
+     * event handler. To handle other named events, add logic to this handler.
+     */    
     public onInvoke(handler: BotHandler): this {
         return this.on('Invoke', handler);
     }

diff --git a/libraries/botbuilder-dialogs/src/prompts/oauthPrompt.ts b/libraries/botbuilder-dialogs/src/prompts/oauthPrompt.ts
@@ -12,14 +12,18 @@ import { PromptOptions, PromptRecognizerResult,  PromptValidator } from './promp
 import { channels } from '../choices/channel';
 import { isSkillClaim } from './skillsHelpers';
 
-// documentation missing
-class TokenExchangeInvokeRequest {
+/**
+ * Request body accepted for a token exchange invoke activity.
+ */
+interface TokenExchangeInvokeRequest {
     id: string;
     connectionName: string;
     token: string;
 }
 
-// documentation missing
+/**
+ * Response body returned for a token exchange invoke activity.
+ */
 class TokenExchangeInvokeResponse {
     id: string;
     connectionName: string;

diff --git a/package.json b/package.json
@@ -7,7 +7,7 @@
     "clean": "lerna run clean",
     "functional-test": "lerna run build && nyc mocha \"libraries/functional-tests/tests/*.test.js\"",
     "browser-functional-test": "cd libraries/browser-functional-tests && node nightwatch.js -e",
-    "test": "lerna run build && nyc mocha \"libraries/bot*/tests/**/ActivityHandler.test.js\"",
+    "test": "lerna run build && nyc mocha \"libraries/bot*/tests/**/*.test.js\"",
     "test:coveralls": "lerna run build && nyc mocha \"libraries/bot*/tests/**/*.test.js\" && nyc report --reporter=text-lcov | coveralls",
     "test-coverage": "nyc mocha \"libraries/bot*/tests/**/*.test.js\"",
     "upload-coverage": "nyc report --reporter=text-lcov | coveralls",