-
Notifications
You must be signed in to change notification settings - Fork 492
Conversation
|
@cleemullins By merging this PR all integration tests won't run until the |
ac68af4 to
c675f4a
Compare
|
We also moved all integration tests accessing network services to a new
|
c675f4a to
74865f1
Compare
johnataylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only question is - does this include the extra build target referred to in the comment?
(its pretty sad that we have to use a macro to control the test framework - anyhow great to have the capability)
|
@johnataylor The compilation symbol/constant is configured in the new Yes, it is included, but take into account it is not a new Target. https://github.com/Microsoft/botbuilder-dotnet/pull/765/files#diff-dfa2c0caf486505728526f3e1095a104R10 |
26c10c7 to
a54ed68
Compare
…te if RUNINTEGRATIONTESTS is not defined
a54ed68 to
a6ed06d
Compare
a6ed06d to
c06bfb9
Compare
|
@JuanAr can we close this now? |
|
@johnataylor I think we should revisit the original objective for this PR. However, while developing mocks we implemented them in a way that, instead of two separated versions of tests (unit & integration tests), the same test uses a flag to conditionally hit the mocks or the external service. This might be a much better approach because it avoids having duplicated tests. Let us know what you think. |
|
Closing this obsolete PR since the approach used in tested changed to an hybrid one. |
Included compilation directive and
[Ignore]attribute to Integration Test classes to make them disabled by default. They run only when explicitly define theRUNINTEGRATIONTESTScompilation constant.Integration tests will be shown as _ Skipped_ in the Test explorer with the message:
These integration tests run only when RUNINTEGRATIONTESTS is defined.