[#6889] CQA to support TokenCredential instead of key #6892
+165
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaavila
added
the
Automation: No parity
tracyboehrer
approved these changes
May 28, 2025
tracyboehrer
pushed a commit
that referenced
this pull request
May 29, 2025
tracyboehrer
added a commit
that referenced
this pull request
May 29, 2025
* Add support for .NET 9.0 (#6887) * Add NET9 and remove NET6 target frameworks * Configure NETAnalyzers version in Directory.Build.props * Update yamls to support NET 9.0 * Update tests to pass on Mac build. * [#6889] CQA to support TokenCredential instead of key (#6892) * Add support for MSI to access CQA service * Use IsNullOrWhiteSpace instead of IsNullOrEmpty * Catch exception in GetTokenAsync call * Fix MemoryStream Converter when serializing (#6888) --------- Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com> Co-authored-by: Joel Mut <62260472+sw-joelmut@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6889
Description
This PR adds the ability to use a Managed Identity ClientId to authenticate to the Language service.
Specific Changes
Microsoft.Bot.Builder.AI.QnA.QnAMakerEndpointclass.QnAMakerDialogto handle the Managed Identity Client Id.QnAMakerDialogclass to configure which authentication the request will use.HttpRequestUtilsclass.Testing
The following images show the 48.customQABot-all-features sample working with both authentication methods, EndpointKey (Emulator) and ManagedIdentityClientId (WebChat)
