Support Sso for SharePoint bot ACEs #6755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracyboehrer
approved these changes
Mar 5, 2024
jevansaks
pushed a commit
to jevansaks/botbuilder-dotnet
that referenced
this pull request
May 10, 2024
* Support Sso for SharePoint bot ACEs * Adding IStorage back in * Adding support for QuickView SSO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This change allows SharePoint Bot Driven Aces to use SSO.
Description
Currently a bot driven ace in SharePoint can only use the magic code flow. This flow is not ideal as it requires a user to copy and paste a code from a different window or at a minimum we get flicker of the window being shown. This change allows us to use the SSO flow so that not authentication prompts are shown.
#minor
Specific Changes
Adds a new cardExtension/token activity for doing a token exchange.
Testing
Used a debug string in SharePoint and copied the bot builder bits locally to produce a bot running on ngrok.