Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#6642] Handle null content - #6654

Merged
tracyboehrer merged 1 commit into
mainfrom
southworks/fix/handle-null-content-streamingRequest
Jul 18, 2023
Merged

[#6642] Handle null content#6654
tracyboehrer merged 1 commit into
mainfrom
southworks/fix/handle-null-content-streamingRequest

Conversation

@ceciliaavila

Copy link
Copy Markdown
Collaborator

Fixes #6642

Description

This PR validates the request's content before using it to create the body of streaming requests.

Specific Changes

  • Added validation of content before reading the data to create the request's body in CreateSteamingRequestAsync.

Testing

The following image shows the handle of the null content.
image

@ceciliaavila ceciliaavila added the Automation: Parity with js The PR needs to be ported to JS label Jun 30, 2023
@ceciliaavila
ceciliaavila requested a review from a team as a code owner June 30, 2023 20:01
@coveralls

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 357955

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.001%) to 78.98%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 93.94%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/CloudAdapter.cs 1 77.3%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
Totals Coverage Status
Change from base Build 356861: 0.001%
Covered Lines: 25937
Relevant Lines: 32840

💛 - Coveralls

@BruceHaley

Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll

@tracyboehrer
tracyboehrer merged commit b83d844 into main Jul 18, 2023
@tracyboehrer
tracyboehrer deleted the southworks/fix/handle-null-content-streamingRequest branch July 18, 2023 14:06
This was referenced May 14, 2026
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: Parity with js The PR needs to be ported to JS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle null Content

5 participants