Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#6616] Telemetry not logging ActivityID and ConversationID#6620

Merged
tracyboehrer merged 3 commits into
mainfrom
southworks/fix/telemetry-not-logging-activityid-and-conversationid
Apr 20, 2023
Merged

[#6616] Telemetry not logging ActivityID and ConversationID#6620
tracyboehrer merged 3 commits into
mainfrom
southworks/fix/telemetry-not-logging-activityid-and-conversationid

Conversation

@erquirogasw

Copy link
Copy Markdown
Contributor

Fixes #6616

Description

This PR adds ActivityID and ConversationID properties to telemetry when using the Direct Line Service App extension.

Specific Changes

  • Added ActivityIdProperty property in TelemetryConstants class.
  • Added ActivityID and ConversationID properties in the Fill methods in TelemetryLoggerMiddleware class.
  • Updated unit tests in TelemetryMiddlewareTests.

Testing

The following images show the properties logged in Application Insights and the unit tests passing.
iCEpwqKIwW (1)
w4N1IsNF4p

@erquirogasw erquirogasw added the Automation: Parity with js The PR needs to be ported to JS label Apr 17, 2023
@erquirogasw erquirogasw requested a review from a team as a code owner April 17, 2023 17:44
@coveralls

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 348112

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 79.082%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/Microsoft.Bot.Streaming/Payloads/StreamManager.cs 1 90.0%
/libraries/Microsoft.Bot.Builder/TelemetryLoggerMiddleware.cs 22 71.24%
Totals Coverage Status
Change from base Build 344537: -0.02%
Covered Lines: 25813
Relevant Lines: 32641

💛 - Coveralls

@BruceHaley

Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll

@tracyboehrer tracyboehrer merged commit c855a1f into main Apr 20, 2023
@tracyboehrer tracyboehrer deleted the southworks/fix/telemetry-not-logging-activityid-and-conversationid branch April 20, 2023 13:26
This was referenced May 14, 2026
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: Parity with js The PR needs to be ported to JS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Telemetry not logging ActivityID and ConversationID.

5 participants