Fixes appsettings.[EnvironmentName].json #5421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it can get the EnviornmentName and load the propper appsettings. Fixed bug in loading appsettings.EnvironmentName.json Added base unit tests
gabog
added
the
Automation: No parity
johnataylor
approved these changes
Apr 2, 2021
joshgummersall
pushed a commit
to microsoft/botbuilder-js
that referenced
this pull request
Apr 2, 2021
Roughly maps to behavior added via microsoft/botbuilder-dotnet#5421
gabog
added a commit
that referenced
this pull request
Apr 5, 2021
* Updated ConfigurationBuilderExtensions to take HostBuilderContext so it can get the EnviornmentName and load the propper appsettings. Fixed bug in loading appsettings.EnvironmentName.json Added base unit tests * Updated Adaptive.Runtime project to target netstandard 2.0 and net core 3.1 * Added conditional references based on target framework * Forced adding ignored files so we can test.
stevengum
pushed a commit
to microsoft/botbuilder-js
that referenced
this pull request
Apr 5, 2021
* fix: azure logs issues Can't log after response is written for some reason. * fix: watch files in dev only * fix: load appsettings files based on NODE_ENV Roughly maps to behavior added via microsoft/botbuilder-dotnet#5421
joshgummersall
added a commit
to microsoft/botbuilder-js
that referenced
this pull request
Apr 5, 2021
* fix: azure logs issues Can't log after response is written for some reason. * fix: watch files in dev only * fix: load appsettings files based on NODE_ENV Roughly maps to behavior added via microsoft/botbuilder-dotnet#5421
stevengum
pushed a commit
to microsoft/botbuilder-js
that referenced
this pull request
Apr 5, 2021
* fix: azure logs issues Can't log after response is written for some reason. * fix: watch files in dev only * fix: load appsettings files based on NODE_ENV Roughly maps to behavior added via microsoft/botbuilder-dotnet#5421
mrivera-ms
pushed a commit
that referenced
this pull request
Apr 6, 2021
* Updated ConfigurationBuilderExtensions to take HostBuilderContext so it can get the EnviornmentName and load the propper appsettings. Fixed bug in loading appsettings.EnvironmentName.json Added base unit tests * Updated Adaptive.Runtime project to target netstandard 2.0 and net core 3.1 * Added conditional references based on target framework * Forced adding ignored files so we can test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5395
Updated ConfigurationBuilderExtensions to take HostBuilderContext so it can get the EnviornmentName and load the proper appsettings.
Fixed bug in loading appsettings.EnvironmentName.json
Added base unit tests ConfigurationBuilderExtensions (we will need to add additional tests for required settings once we refactore appsettings in R14.
This PR also updated the Microsoft.Bot.Builder.Dialogs.Adaptive.Runtime project to target netstandard2.0 and netcoreapp3.1.
@peterinnesmsft, we will need to update the generators code to pass HostBuilderContext in program.cs once this PR gets cherrypicked into the R13 branch and we update the references.