Cherry-Pick to 4.12: Change ChoiceSet to support LG (#5309) #5312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make ChoiceSet implement ITemplate<ChoiceSet> Fix ExpressionProperty Throw in Try method that shouldn 't throw Updated ConfirmInput and ChoiceInput to use ITemplate>.BindData() if expression is template reference. Added unit tests * update schema * fix schema definition for choices
mrivera-ms
approved these changes
Mar 12, 2021
gabog
reviewed
Mar 12, 2021
| if (_modelFolder == null) | ||
| { | ||
| throw new ArgumentNullException($"Missing `ModelFolder` information."); | ||
| #pragma warning disable CA2208 // Instantiate argument exceptions correctly |
Contributor
There was a problem hiding this comment.
I know this is a cherry pick but I think it may have been better to use InvalidOperationException here with a descriptive message rather than argumentnullexception with a pragma (The exception that is thrown when a method call is invalid for the object's current state.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ChoiceSet implement ITemplate
Fix ExpressionProperty Throw in Try method that shouldn 't throw
Updated ConfirmInput and ChoiceInput to use ITemplate>.BindData() if expression is template reference.
Added unit tests
update schema
fix schema definition for choices
Fixes #
Description
Specific Changes
Testing